-
-
Notifications
You must be signed in to change notification settings - Fork 13
docs: improve README with quickstart, examples, and fork support #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: parkerbxyz <17183625+parkerbxyz@users.noreply.github.com>
Co-authored-by: parkerbxyz <17183625+parkerbxyz@users.noreply.github.com>
Co-authored-by: parkerbxyz <17183625+parkerbxyz@users.noreply.github.com>
parkerbxyz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot I think we should move content from the Events section to Working with pull requests from forks. Please also use sentence case for headings.
…EN scope Co-authored-by: parkerbxyz <17183625+parkerbxyz@users.noreply.github.com>
Restructured the README with sentence case headings. The Events section content has been moved into "Working with pull requests from forks" with sub-sections for each event type. Commit: e5f8d2a |
pull_request_target and PRs from forks
Expanded README with quickstart, basic and complete workflow examples, detailed input documentation, and clearer instructions for handling pull requests from forks. Added recommendations for using GitHub App tokens and clarified permissions and event usage for secure automation.
|
@copilot I made some additional changes. Please ensure the pull request title and description are up-to-date. |
Updated the PR title to "docs: improve README with quickstart, examples, and fork support" and refreshed the description to reflect all changes including the quickstart section, input documentation, and improved usage examples you added. |
pull_request_target and PRs from forksReplaced outdated GitHub Actions security link with the current documentation on mitigating risks of untrusted code checkout.
Updated README to clarify that workflows triggered by the pull_request event run in the fork's context, which is more secure than pull_request_target. Expanded security warning for pull_request_target to highlight risks of running untrusted code and linked to relevant documentation.
|
@copilot I made more updates. Please ensure the PR title and description are up-to-date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR significantly improves the README documentation to better support fork-based contributions and provide clearer usage patterns. The changes transform the documentation from a single basic example into a comprehensive guide with multiple usage scenarios and clear security guidance.
Key changes:
- Added quickstart section and reorganized examples from basic to advanced usage patterns
- Documented all action inputs (
comment,event,token) with descriptions and defaults - Added dedicated section on handling pull requests from forks with two approaches: GitHub App tokens (recommended) and
pull_request_targetevent (with security warnings)
The PR title and description are current. The recent updates enhanced security documentation by:
No changes needed to the title or description.
Updated recommendation: The PR title should be changed to use Suggested PR Title: This follows the conventional commits format with a scope specifying that the README is the file being documented. |
Comprehensively improves the README documentation to better support users working with pull requests from forks and provides clearer usage examples.
Changes Made
Documentation Structure
comment,event,token) with defaults and descriptionsFork Support Documentation
pull_requestandpull_request_targetevents are supportedpull_requesteventpull_request_targetevent with security warningsPermissions and Security
pull-requests: writepermission is only needed when using the built-inGITHUB_TOKEN[!CAUTION]callout forpull_request_targetsecurity risks, highlighting repository compromise and secret exposure riskscontents: readandpull-requests: writeREQUEST_CHANGESblocking PR mergesStyle and Organization
Fixes #33
Original prompt
This section details on the original issue you should resolve
<issue_title>Support for PR's from forks!</issue_title>
<issue_description>I know currently this workflow only supports
pull_requestevents, but it would much better if this can supportpull_request_targetevent too because most PR's usually from contributor's fork! Is there any chance this will be added any soon?This is what I get now when I used it on
pull_request_targetevent.Let me know if that does the trick! </comment_new>
<comment_new>@parkerbxyz
The OP specifically asked about using
pull_request_target, which I think should work if the permissions are specified...Fixes #33
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.