Add quick item childen (can be nested)#27
Add quick item childen (can be nested)#27rafaeldelucena wants to merge 12 commits intoparkouss:masterfrom
Conversation
|
This looks nice - could you rebase the code on master please, now that you fixed the travis tests (+1 !) it should compile and every test should pass. Also, if you are motivated, a functional test would be awesome for the new addition. Though I understand if you don't have the time, and I will merge it like this if you want to. |
|
Ok, I'll do it! |
thony418
left a comment
thony418
left a comment
There was a problem hiding this comment.
The proposed fix should fix Travis build
rafaeldelucena
force-pushed
the
add-quick-item-children
branch
6 times, most recently
from
dbe1d9e to
58b2fc6
Compare
|
I'm writing some functional tests for QML and maybe I'll also create the unit tests for this feature. |
|
awesome :) |
rafaeldelucena
force-pushed
the
add-quick-item-children
branch
3 times, most recently
from
626381a to
15f6807
Compare
rafaeldelucena
force-pushed
the
add-quick-item-children
branch
from
15f6807 to
d9df8d5
Compare
rafaeldelucena
force-pushed
the
add-quick-item-children
branch
2 times, most recently
from
342b0d5 to
ccd8692
Compare
|
Hi, are there any updates on this PR? |
|
Hello @SnkE, the blocker is testing this in Windows, I've created a QML application to make functional tests of this feature. If you have some ideas please let me known. |
rafaeldelucena
force-pushed
the
add-quick-item-children
branch
from
33bf357 to
ac4aa77
Compare
rafaeldelucena
force-pushed
the
add-quick-item-children
branch
from
e3f43e5 to
cbe445a
Compare
3 participants
This PR aims to enable to get children from items (also nested items)