Open
Conversation
Contributor
Author
|
Note: A lot of the 2/3 compat complexity (like metaclasses that work on both version) could be avoided by moving from nose + custom testing baseclass to pytest 🙂 |
The 2to3 option in setup.py had some undesired side effects. Using `six` as a compatibility library is much cleaner. The code should now be compatible with both Python 2 and 3. The future import should always be used for new Python files.
dbrgn
changed the title
Contributor
Author
|
Should be ready now (according to the testsuite). @ubruhin does this solve the issues you were having? |
Contributor
Probably yes, you can now remove the workaround in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2to3 option in setup.py had some undesired side effects. Using
sixas a compatibility library is much cleaner. (Specifically, @ubruhin had some issues with 2to3 doing buggy things.)The code should now be compatible with both Python 2 and 3. The future import should always be used for new Python files.
Still mostly WIP, I'm creating the PR to trigger CI. Also, it's based on #59, so that should be handled first.