Merged
Conversation
…er than bypass errors
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive validation and UX improvements to the Boulder configuration system. It introduces schema validation using Pydantic models with unit conversion capabilities, enhances CLI functionality with port management and verbose logging, and updates the UI to display temperatures in Celsius instead of Kelvin.
- Adds Pydantic-based validation with dynamic unit conversion using Pint
- Implements verbose logging system with CLI support for better debugging
- Updates temperature display from Kelvin to Celsius throughout the UI
- Integrates validation into all configuration loading workflows
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| boulder/validation.py | New validation module with Pydantic models and unit conversion |
| boulder/verbose_utils.py | New verbose logging utilities |
| tests/test_config_validation.py | Comprehensive validation test suite |
| boulder/config.py | Integrates validation into config loading functions |
| boulder/cli.py | Enhanced CLI with port management and verbose mode |
| boulder/layout.py | Updates temperature labels to Celsius |
| boulder/utils.py | Updates temperature unit display |
| environment.yml, pyproject.toml, ci/environment-ci.yml | Adds pint and pydantic dependencies |
| configs/*.yaml | YAML format updates for STONE standard |
| tests/test_data/invalid/*.yaml | Invalid test fixtures |
| boulder/app.py | Enhanced server startup with verbose logging |
| boulder/callbacks/*.py | Callbacks updated with verbose logging and temperature units |
| boulder/cantera_converter.py | Updated with verbose logging |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add various small but important improvements to Boulder :
boulder some_file.yaml --verbose