Add method to support requests to Ads API.#38
Open
jamesvl wants to merge 1 commit intoparroty:masterfrom
jamesvl:master
Open
Add method to support requests to Ads API.#38jamesvl wants to merge 1 commit intoparroty:masterfrom jamesvl:master
jamesvl wants to merge 1 commit intoparroty:masterfrom
jamesvl:master
Conversation
At this time, supports bare requests going to the new URL.
Owner
|
Thanks for the PR. I'm wondering how the external API signature should be (as defined in https://github.com/parroty/extwitter/blob/master/lib/extwitter.ex). I'm looking the site https://dev.twitter.com/ads/overview, but haven't been able to find the good reference (API list for the endpoint). Do you have any insights? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this time, supports bare requests going to the new URL.
I don't anticipate that there will be a need to add methods to emulate all of the Ads API functionality - using this request method directly should be enough. (And since their ads API is still at version "0", it's subject to changes anyway.)
p.s. still learning how Elixir testing works - I'm not familiar with the VCR fixtures in use. Possible test to add would be like this: