Skip to content

chore: update error message on get filters #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

chore: update error message on get filters #1440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/handlers/http/users/filters.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ use actix_web::{
http::header::ContentType,
web::{self, Json, Path},
};
use chrono::Utc;
use http::StatusCode;
use serde_json::Error as SerdeError;
use ulid::Ulid;

pub async fn list(req: HttpRequest) -> Result<impl Responder, FiltersError> {
let key =
Expand All @@ -51,7 +51,9 @@ pub async fn get(
return Ok((web::Json(filter), StatusCode::OK));
}

Err(FiltersError::Metadata("Filter does not exist"))
Err(FiltersError::Metadata(
"Filter does not exist or user is not authorized",
))
}

pub async fn post(
Expand All @@ -60,7 +62,7 @@ pub async fn post(
) -> Result<impl Responder, FiltersError> {
let mut user_id = get_user_from_request(&req)?;
user_id = get_hash(&user_id);
let filter_id = get_hash(Utc::now().timestamp_micros().to_string().as_str());
let filter_id = Ulid::new().to_string();
filter.filter_id = Some(filter_id.clone());
filter.user_id = Some(user_id.clone());
filter.version = Some(CURRENT_FILTER_VERSION.to_string());
Expand All @@ -80,7 +82,9 @@ pub async fn update(
user_id = get_hash(&user_id);
let filter_id = filter_id.into_inner();
if FILTERS.get_filter(&filter_id, &user_id).await.is_none() {
return Err(FiltersError::Metadata("Filter does not exist"));
return Err(FiltersError::Metadata(
"Filter does not exist or user is not authorized",
));
}
filter.filter_id = Some(filter_id.clone());
filter.user_id = Some(user_id.clone());
Expand All @@ -102,7 +106,9 @@ pub async fn delete(
let filter = FILTERS
.get_filter(&filter_id, &user_id)
.await
.ok_or(FiltersError::Metadata("Filter does not exist"))?;
.ok_or(FiltersError::Metadata(
"Filter does not exist or user is not authorized",
))?;

PARSEABLE.metastore.delete_filter(&filter).await?;
FILTERS.delete_filter(&filter_id).await;
Expand Down
Loading