Add new fields to Quote object: uuid, order_numbers, metadata#76
Merged
adeang47 merged 5 commits intopart-os:masterfrom Oct 23, 2025
Merged
Add new fields to Quote object: uuid, order_numbers, metadata#76adeang47 merged 5 commits intopart-os:masterfrom
adeang47 merged 5 commits intopart-os:masterfrom
Conversation
jeccles12
commented
Sep 25, 2025
jeccles12
commented
- Added uuid field (Optional[str]) to Quote class
- Added order_numbers field (List[str]) to Quote class
- Added metadata field (Optional[Dict]) to Quote class
- Updated QuoteDetailsMapper to handle new fields
- Added special handling for order_numbers default value
- Maintains backward compatibility with existing code
adeang47
reviewed
Oct 8, 2025
adeang47
approved these changes
Oct 8, 2025
adeang47
reviewed
Oct 8, 2025
djoq
reviewed
Oct 21, 2025
| validator=attr.validators.optional(attr.validators.instance_of(str)), | ||
| default=None | ||
| ) | ||
| order_numbers: List[str] = attr.ib( |
djoq
reviewed
Oct 21, 2025
paperless/objects/quotes.py
Outdated
| default=None | ||
| ) | ||
| order_numbers: List[str] = attr.ib( | ||
| converter=optional_convert(convert_iterable(str)), |
Author
|
@andrew-deangelis47 I think this should be good now I updated the mock data and fixed something else on the types for this new field. |
Collaborator
|
@jeccles12 do you mind tagging the branch as |
jeccles12
force-pushed
the
quote-header-update
branch
from
b201411 to
ca7d53b
Compare
Author
|
@andrew-deangelis47 should be all set |
added 5 commits
October 23, 2025 12:07
- Added uuid field (Optional[str]) to Quote class - Added order_numbers field (List[str]) to Quote class - Added metadata field (Optional[Dict]) to Quote class - Updated QuoteDetailsMapper to handle new fields - Added special handling for order_numbers default value - Maintains backward compatibility with existing code
- Changed order_numbers converter from convert_iterable(str) to a simple lambda - convert_iterable is designed for attrs classes, not primitives like strings - Added converter that handles None values and converts to empty list - Fixed mapper to ensure order_numbers defaults to empty list when None
- Added uuid field to quote.json mock data - Added metadata field to quote.json mock data with sample values - Added test assertions to verify new fields are accessible - All 57 tests pass
adeang47
force-pushed
the
quote-header-update
branch
from
ca7d53b to
b72b044
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.