Skip to content

Make country_code optional for Account and Contact #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adeang47 merged 1 commit into from
Nov 25, 2025
Merged

Make country_code optional for Account and Contact #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions paperless/objects/customers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,14 @@ class Account(
_json_encoder = AccountEncoder

name: str = attr.ib(validator=attr.validators.instance_of(str))
country_code: str = attr.ib(validator=attr.validators.instance_of((str, object)))

# not required for instantiation
billing_addresses = attr.ib(
default=[], converter=optional_convert(convert_iterable(BillingAddress))
)
country_code: str = attr.ib(
default=NO_UPDATE, validator=attr.validators.instance_of((str, object))
)
created = attr.ib(
default=NO_UPDATE, validator=(attr.validators.instance_of((str, object)))
)
Expand Down Expand Up @@ -312,12 +314,14 @@ class Contact(
email: str = attr.ib(validator=attr.validators.instance_of(str))
first_name: str = attr.ib(validator=attr.validators.instance_of(str))
last_name: str = attr.ib(validator=attr.validators.instance_of(str))
country_code: str = attr.ib(validator=attr.validators.instance_of((str, object)))

# not required for instantiation
address = attr.ib(
default=NO_UPDATE, converter=optional_convert(convert_cls(Address))
)
country_code: str = attr.ib(
default=NO_UPDATE, validator=attr.validators.instance_of((str, object))
)
created = attr.ib(
default=NO_UPDATE, validator=(attr.validators.instance_of((str, object)))
)
Expand Down
13 changes: 13 additions & 0 deletions tests/unit/test_contacts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ def setUp(self):
with open('tests/unit/mock_data/contact.json') as data_file:
self.mock_contact_json = json.load(data_file)

def test_create_contact_obj_with_only_required_args(self):
# should not raise any error
Contact(
account_id = 1,
email = "contact@paperlessparts.com",
first_name = "Contact",
last_name = "Paperless"
)

def test_get_contact(self):
self.client.get_resource = MagicMock(return_value=self.mock_contact_json)
c = Contact.get(1)
Expand Down Expand Up @@ -94,6 +103,10 @@ def setUp(self):
with open('tests/unit/mock_data/account.json') as data_file:
self.mock_account_json = json.load(data_file)

def test_create_account_with_only_required_args(self):
# should not raise any error
Account(name="Account Name")

def test_get_account(self):
self.client.get_resource = MagicMock(return_value=self.mock_account_json)
a = Account.get(1)
Expand Down