Fix for compilation warnings in bitwise operations#25
Open
psigen wants to merge 1 commit intoparticle-iot:masterfrom
Open
Fix for compilation warnings in bitwise operations#25psigen wants to merge 1 commit intoparticle-iot:masterfrom
psigen wants to merge 1 commit intoparticle-iot:masterfrom
Conversation
The ADXL362 driver embedded in this header throws compiler warnings about bitwise arithmetic. This is because there are one-liners containing multiple bitwise operators with no parens. These are generally not recommended because they depend on operator precedence to evaluate in the correct order, and that can be quite tricky to get right. This commit simply adds some parens that follow `C` operator precedence (doing what the statement was already doing, but explicitly).
Author
|
@jenesaisdiq are you the right person to look at this? |
Contributor
|
Oh nice, thanks @psigen. In the current version in the libraries system (0.1.11) that library has been pulled out into an include instead of my crummy copy/paste, but it looks like that hasn't been posted back to here yet. If you grab it using Build, Dev, or the CLI it should have that via a library.properties file... but I bet the included ADXL362 lib still has the problem. I'm going to wait on merging this in, and plan to get the repo up to date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ADXL362 driver embedded in this header throws compiler warnings about bitwise arithmetic. This is because there are one-liners containing multiple bitwise operators with no parens. These are generally not recommended because they depend on operator precedence to evaluate in the correct order, and that can be quite tricky to get right.
This commit simply adds some parens that follow
Coperator precedence (doing what the statement was already doing, but explicitly).