Open
Conversation
gilrrei
force-pushed
the
refactor_pipapo
branch
from
3c740a3 to
54a3156
Compare
c-p-schmidt
reviewed
Dec 4, 2025
gilrrei
force-pushed
the
refactor_pipapo
branch
2 times, most recently
from
c719cf2 to
cf4a165
Compare
gilrrei
force-pushed
the
refactor_pipapo
branch
from
cf4a165 to
fc38c3e
Compare
ppraegla
approved these changes
Dec 18, 2025
| if not lengths_property: | ||
| return 0 | ||
|
|
||
| if len(set(lengths_property)) == 1: |
Contributor
There was a problem hiding this comment.
Suggested change
| if len(set(lengths_property)) == 1: | |
| if len(lengths_property) == 1: |
lengths_property already is a set, right?
| def get_contacts(self, n_particles: int) -> dict[int, set[int]]: | ||
| """Get contacts of the interface container. | ||
|
|
||
| Only works in particle index is two dimensional. |
Contributor
There was a problem hiding this comment.
Suggested change
| Only works in particle index is two dimensional. | |
| Only works if particle index is two dimensional. |
| def get_connected_clusters(self, n_particles: int) -> list[list[int]]: | ||
| """Get the connected clusters. | ||
|
|
||
| I.e. particle sets which a in contact with each other. |
Contributor
There was a problem hiding this comment.
Suggested change
| I.e. particle sets which a in contact with each other. | |
| I.e. particle sets which are in contact with each other. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does some major stuff.
Metastuff
Pipapo containers
particles.data[<field_name>](reduced a lot of code)idsanymore. This was confusing and introduced some unnecessary complications. (The ids can still be stored as a data array)Particleobject anymoreParticleParticleandParticleWallcontainers were merged intoInterfaceContainerGeometries
Domainobject, currently onlyBoxBoundaryobject, currently onlyPlaneMisc
_safeattribute. If set to false, the lengths of the arrays are no longer checked; this might be nice for performance@c-p-schmidt this will change some stuff for other codes, but for the better :)