[DRAFT] fix: Constant-fold inline struct literal path access in TrinoRewriter#147
Closed
[DRAFT] fix: Constant-fold inline struct literal path access in TrinoRewriter#147
Conversation
When a UNION ALL query contains inline struct literal path access like
`{'x': t1.b, 'y': t1.c}."x"`, the TrinoRewriter now resolves it at
rewrite time to the matching field value (e.g., `t1.b`). This is
necessary because none of Scribe's transpilation targets (Trino, Spark,
Redshift) support PartiQL's `{key: value, ...}` struct literal syntax.
The issue was specifically triggered for UNION ALL queries where SQL
Select columns get transcribed to a literal struct.
Added a Trino sandbox test suite to reproduce and verify the fix.
am357
force-pushed
the
chore-union-all-trino
branch
from
054095c to
d786102
Compare
Contributor
|
This looks a partial duplication of the PR which supports struct transpilation, however it does not solve the issue. I might mislead the investigation. We might need to provide a template for customer to ask for origin query, transcribed SQL dialect, schema info and version info. |
Author
That seems right. I will close this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a UNION ALL query contains inline struct literal path access like
{'x': t1.b, 'y': t1.c}."x", the TrinoRewriter now resolves it at rewrite time to the matching field value (e.g.,t1.b). This is necessary because none of Scribe's transpilation targets (Trino, Spark, Redshift) support PartiQL's{key: value, ...}struct literal syntax.The issue was specifically triggered for UNION ALL queries where SQL Select columns get transcribed to a literal struct.
Added a Trino sandbox test suite to reproduce and verify the fix.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.