chore: Upgrade partiql-lang-kotlin submodule to v1.3.10#148
Open
chore: Upgrade partiql-lang-kotlin submodule to v1.3.10#148
Conversation
Update submodule to v1.3.10 which reverts the DATE_ADD to interval arithmetic lowering (partiql/partiql-lang-kotlin#1896). DATE_ADD now passes through as a function call rather than being rewritten to INTERVAL + datetime during planning. Update expected test outputs for all targets (PartiQL, Trino, Spark, Redshift) to reflect the new DATE_ADD behavior: - PartiQL: DATE_ADD passes through unchanged - Trino: date_add('unit', n, expr) - Redshift: DATEADD(UNIT, n, expr) - Spark: expr + make_interval(...)
xd1313113
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update submodule to v1.3.10 which reverts the
DATE_ADDto interval arithmetic lowering (partiql/partiql-lang-kotlin#1896).DATE_ADDnow passes through as a function call rather than being rewritten toINTERVAL + datetimeduring planning.Update expected test outputs for all targets (PartiQL, Trino, Spark, Redshift) to reflect the new DATE_ADD behavior:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.