Run using node20 (not node16)

[MPV]

What

Let's start runs.using: 'node20' in this action.

Why

This action has started failing for us this week, where we're getting errors such as:

TypeError: Cannot read properties of null (reading 'length')
      at getStateLength (/home/runner/_work/_actions/pass-culture-github-actions/gcs-cache/a15865adf837a570fa52671cab4d83baad2aceab/dist/main/index.js:198:27987)
      at shift (/home/runner/_work/_actions/pass-culture-github-actions/gcs-cache/a15865adf837a570fa52671cab4d83baad2aceab/dist/main/index.js:198:27851)
      at Duplexify._forward (/home/runner/_work/_actions/pass-culture-github-actions/gcs-cache/a15865adf837a570fa52671cab4d83baad2aceab/dist/main/index.js:177:11566)
      at PassThrough.onreadable (/home/runner/_work/_actions/pass-culture-github-actions/gcs-cache/a15865adf837a570fa52671cab4d83baad2aceab/dist/main/index.js:177:10980)
      at PassThrough.emit (node:events:519:28)
      at emitReadable_ (node:internal/streams/readable:832:12)
      at process.processTicksAndRejections (node:internal/process/task_queues:81:21)
  Node.js v20.13.1

We also get this warning:

The following actions uses Node.js version which is deprecated and will be forced to run on node20: pass-culture-github-actions/gcs-cache@v1.0.0 For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

...where they say:

Following on from our warning in workflows using Node16 we will start enforcing the use of Node20 rather than Node16 on the 3rd of June.

[MPV]

@kopax could you take a look? 🙏

[MPV]

It seems this change doesn't fix the problem (it's just what happens automatically behind the scenes inside the runners, that they automatically pick node20 over node16 nowadays).

There is a workaround available for now, setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true at the workflow level (sadly not at the step/action level).

Would you be up for looking into why this action doesn't work on NodeJS 20?

I have tried merging the equivalent PR of this (and using my own fork), but the result is still the error above:

• Run using node20 (not node16) pagero/gcs-cache#1

[MPV]

By adding source maps...

• chore: npm run package should create source maps (for troubleshooting) pagero/gcs-cache#2

...I was able to get a clearer error / stack trace:

  /home/runner/_work/_actions/pagero/gcs-cache/4857aab4515c00e04051f4da50c145f2a1d11019/dist/webpack:/gcs-cache/node_modules/stream-shift/index.js:16
      return state.buffer[0].length
  ^
  TypeError: Cannot read properties of null (reading 'length')
      at getStateLength (/home/runner/_work/_actions/pagero/gcs-cache/4857aab4515c00e04051f4da50c145f2a1d11019/dist/webpack:/gcs-cache/node_modules/stream-shift/index.js:16:1)
      at shift (/home/runner/_work/_actions/pagero/gcs-cache/4857aab4515c00e04051f4da50c145f2a1d11019/dist/webpack:/gcs-cache/node_modules/stream-shift/index.js:6:1)
      at Duplexify._forward (/home/runner/_work/_actions/pagero/gcs-cache/4857aab4515c00e04051f4da50c145f2a1d11019/dist/webpack:/gcs-cache/node_modules/duplexify/index.js:170:1)
      at PassThrough.onreadable (/home/runner/_work/_actions/pagero/gcs-cache/4857aab4515c00e04051f4da50c145f2a1d11019/dist/webpack:/gcs-cache/node_modules/duplexify/index.js:136:1)
      at PassThrough.emit (node:events:519:28)
      at emitReadable_ (node:internal/streams/readable:832:12)
      at processTicksAndRejections (node:internal/process/task_queues:81:21)

[MPV]

Could it be this upstream issue / solution?

• fix: Cannot read properties of null (reading length) in stream-shift mafintosh/duplexify#40

Which is added via @google-cloud/storage, fixed in version 7.8.0:

• fix: Cannot read properties of null (reading length) in stream-shift googleapis/nodejs-storage#2422

[MPV]

Here's a separate PR trying to make that specific change:

• chore: upgrade @google-cloud/storage to 7.8.0 (stream-shift issue) #2