1839 merkle payout #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tim-schultz
commented
Dec 23, 2023
tim-schultz
commented
commit 9d15170 Author: Lucian Hymer <lucian@lucianhymer.com> Date: Wed Dec 20 11:04:13 2023 -0700 mob next [ci-skip] [ci skip] [skip ci] lastFile:test/GitcoinIdentityStaking.ts commit 63a0c7b Author: Lucian Hymer <lucian@lucianhymer.com> Date: Wed Dec 20 09:19:10 2023 -0700 mob start [ci-skip] [ci skip] [skip ci]
nutrina
reviewed
Dec 26, 2023
|
|
||
| address public burnAddress; | ||
|
|
||
| mapping(uint256 round => uint192 amount) public totalSlashed; |
Contributor
There was a problem hiding this comment.
Will probably be needed when tracking the burn operations.
nutrina
reviewed
Dec 26, 2023
Comment on lines
+67
to
+69
| mapping(bytes32 => bool) public slashProofHashes; | ||
|
|
||
| mapping(bytes32 => bool) public slashMerkleRoots; |
Contributor
There was a problem hiding this comment.
It would be great if we could drop these 2 mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.