Merged
Conversation
…es unit testing with phpunit mocks, as they are currently cleanuped before asserting.
DanielBadura
commented
Apr 2, 2026
| self::assertSame(1, $test::getCount()); | ||
| } | ||
|
|
||
| public function testVisitedDoubleAssert(): void |
Member
Author
There was a problem hiding this comment.
this was a weird test which aimed for infeciton 100%, not needed anymore.
| $test | ||
| ->when( | ||
| static fn () => 'no aggregate as return', | ||
| static fn () => null, |
| $test = $this->getTester(); | ||
|
|
||
| $notifier = $this->createMock(Notifier::class); | ||
| $notifier->expects($this->once())->method('notify'); |
Member
Author
There was a problem hiding this comment.
without these changes, phpunit would always say that the function was never called.
Member
Author
|
BC-Check unrelated due to PHPunit changes internally. |
DavidBadura
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move execution into
wheninstead of the#[After]hook. This enables unit testing with phpunit mocks, as they are currently cleanuped before asserting.