HMS integration, split library into modules#11
Open
AndrazP wants to merge 11 commits intopatloew:mainfrom
Open
HMS integration, split library into modules#11AndrazP wants to merge 11 commits intopatloew:mainfrom
AndrazP wants to merge 11 commits intopatloew:mainfrom
Conversation
Separate CoLocation into two implementations: 1. `CoLocationGms` - GMS implementation 2. `CoLocationHms` - HMS implementation Let the `CoLocation.from` decide which `locationServicesSource` to use: when both GMS and HMS are available then use the GMS. Create `LocationRequest` and `LocationSettingsRequest` which are wrappers to the platform related classes and use them to define requests without using specific (GMS/HMS) classes. Change the minSdkVersion to 19 (HMS requirement). Create separate tests for both tools.
Add HMS integration
Add ability to switch between location providers.
Modify Sample app to be able to test HMS on Huawei devices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey
I took OKatrych's PR and split the integrations into separate libraries.
Other changes:
You can try out the changes by integrating:
Let me know what you think.