SpiGot 1.13 API update #149
Conversation
BukkitCommon: Updated SIGN_POST to SIGN (2 times) BukkitCommon: Removed a blank line in imports (formatter did this) BukkitConnector: Sorted Imports BukkitConnector: Updated SIGN_POST to SIGN (2 times) BukkitConnector Updated LEAVES to each LEAF type SerializableFireworkEffectMeta: Changed FIREWORK_CHARGE to FIREWORK_STAR SerializableFireworkMeta: Changed FIREWORK to FIREWORK_ROCKET !! SerializableSkullMeta: Changed SKULL_ITEM to PLAYER_HEAD (Please review)
BukkitListener updated PlayerPickupEvent to EntityPickupEvent NBTTools: updated newInstance from deperecated Call NBTTools: Changed type of nbtTagCompound from Class to Class<?>, this prevents warnings and does effectively the same as before HyperWebAPI: updated deprecated newInstance Access to new Access HyperWebAPI: updated construction of Character to use valueOf as proposed by Deprecation
For this, the getOwner() method was split into getOwnerName() and getOwnerUUID() The UUID is serialized, while the Name is retrieved from Bukkit
Enchantments have been updated to use NamespacedKeys. Currently this only works for vanilla enchantments, other enchantments break! The getEnchantmentName() method has been refactored to return NamespacedKey and is now called getEnchantmentKey() The method getEnchantmentKeyString() method has been added, which returns the Key String of the NamespacedKey referencing Classes have been updated accordingly
|
Known Issues: |
Java does respect order of conditions unlike other C-like languages.
Fixes missing @OverRide and is easier to read
Java checks in CNF not DNF
ho can't be null at this location (checked ~10 lines above)
shop can only be null at that location Cleared several blank lines
Sockets are now managed by 'try-with' which automatically closes them when no longer needed/used
|
@RegalOwl I'm done for now. |
Cmethod is now called 'getKeys' in minecraft which is a more apropriate name
|
Ready to merge |
Create a debug.mode file or folder in the HyperConomy-Config folder. Start the Server A materials.list file is written And a LogEntry tells you that it has been written
now includes Potion effects and null checks
Fixes #148
Changed no longer available maven repository to a new one, that should work for now
+HyperAccount Documentation +HyperAccount updateBalance(...) function ~HyperAccount hasBalance(...) changed to 'default' from 'public' ~HyperAccount Sorted Class-Members
Fixed #3 Removed unnecessary blank line
Fixed #3 Removed unnecessary blank line
|
Well this is certainly interesting xD welp I might have done work for nothing now. Well if you can call it that.... Is there at least anything useful we can take from this? What I did there works without issues afaik (I didn't used Maven so I didn't update any refs) have been running it in production for a while without issues #156 |
|
One thing we could do is that we could use Material.values() for the items instead the csv, and for enchanting and stuff, that might be a good idea for the future? I get that its for the price but there should be possibly a better solution to that .... |
2 participants
Updates several classes to work with the updated API of spigot and CB
Please review the changes made before merging, since some of them WILL break serialization and simple updating.
Fixes #142
Fixes #143
Fixes #148
Fixes #150
Fixes #153