skip previous trained batches#42
Open
aws-zhenguo wants to merge 1 commit intomain_11-07-24_gpu_baselinefrom
Open
skip previous trained batches#42aws-zhenguo wants to merge 1 commit intomain_11-07-24_gpu_baselinefrom
aws-zhenguo wants to merge 1 commit intomain_11-07-24_gpu_baselinefrom
Conversation
|
|
||
| # skip previous batches | ||
| for i in range(self.step): | ||
| self.vlog(3, f"skipping batch for step {i}") |
There was a problem hiding this comment.
Do we need to add any unit tests for this change?
Collaborator
Author
There was a problem hiding this comment.
No unit tests planed for now since these are not merging to upstream.
aws-zhenguo
force-pushed
the
replay_gpu
branch
2 times, most recently
from
2fd02ba to
1759e72
Compare
aws-zhenguo
force-pushed
the
replay_gpu
branch
from
1759e72 to
f3d8135
Compare
Collaborator
|
LGTM. |
Collaborator
Author
tested in both GPU and TRN. should we merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.