Skip to content

fix(columnManagementModal): refactor to use ListManager in modal #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(columnManagementModal): refactor to use ListManager in modal #815

wants to merge 2 commits into from
+369 −149

Conversation

nicolethoen
Copy link
Contributor

@nicolethoen nicolethoen commented Sep 18, 2025 •
edited
Loading

Closes #808

Written with assistance of Claude code

@patternfly-build
Copy link

patternfly-build commented Sep 18, 2025 •
edited
Loading

Preview: https://react-component-groups-pr-component-groups-815.surge.sh

A11y report: https://react-component-groups-pr-component-groups-815-a11y.surge.sh

thatblindgeye
thatblindgeye approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really just some nits/things that pre-existed prior to this PR so nothing blocking this going in. A couple of the things would be good as a followup to tackle (I can put something up if we're able to get this merged in sooner than later)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelhala karelhala karelhala approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ListManager to be used in ColumnManagementModal
4 participants
@nicolethoen @patternfly-build @karelhala @thatblindgeye