Adding bounding_box defaults and wcs support to render_model.#3
Open
patti wants to merge 82 commits intoboundingboxesfrom
Open
Adding bounding_box defaults and wcs support to render_model.#3patti wants to merge 82 commits intoboundingboxesfrom
bounding_box defaults and wcs support to render_model.#3patti wants to merge 82 commits intoboundingboxesfrom
Conversation
If the 'file' argument contains a network location, the method now downloads it via download_file and operates on the local copy.
astropy/modeling/core.py
Outdated
There was a problem hiding this comment.
The origin option can be removed.
Hard-code to use 0.
There's some info why here and I can explain in the next hangout.
Basically – It's better to have a convention and use it consistently instead of letting the user configure this.
The if statement is redundant because its decision-making will be done by the subsequent for loop.
Simplified if statement.
…ainer and OrderedParameter, respectively. This required removing a bunch of code that checked for consistency between the param_names attribute and the names of Parameter attributes. However, I think these checks are mostly moot at this point, and were needed more for transitioning of the interface between versions 0.3 and 0.4 and up. I think with any newer code it's not an issue (and even with older code this was a check against developer error, not user error). To be clear, I updated the documentation. Also had to remove one test that was no longer relevant.
… currently implemented.
…scriptorContainer for FrameAttribute and BaseFrame. This *mostly* obviates the need for BaseFrame.get_frame_attr_names(). However, the frame_attributes dict created by OrderedDescriptorContainer is different, as it maps to the actual descriptor objects themselves (retrieved from BaseFrame.__dict__ rather than getattr(BaseFrame, attr_name)). There is a lot of code in the coordinates package that assumes the latter behavior, so for now I left BaseFrame.get_frame_attr_names() in place, and just adapted it to use the new interface.
…y/astropy-helpers#158, which is needed for the docs to build correctly. Also fixed several docstrings that weren't being handled correctly by Sphinx due to use of the InheritDocstrings metaclass (not exactly sure why it wasn't a problem previously though...).
Simplify coordinates/baseframe.py
Update imports for new release of IPython/Jupyter
Make stat.sigma_clip deal with/skip NaN values
…que=True Test with update=True also added since the line the issue arises in also includes update
Correctly handle adding commentary cards in Header.extend in edge cases
OrderedDescriptor and OrderedDescriptorContainer
Converts (2, 3) to [2][3]
If the argument is a pointer return ‘*_name’, else return ‘_name’
Fix erfa warning when passing arrays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.