Fix _render_string_type signature to accept name, length, collation e…#77
Open
ElIsaac wants to merge 1 commit intopauldex:mainfrom
Open
Fix _render_string_type signature to accept name, length, collation e…#77ElIsaac wants to merge 1 commit intopauldex:mainfrom
ElIsaac wants to merge 1 commit intopauldex:mainfrom
Conversation
Contributor
|
Thank you for your contribution, @ElIsaac. The issue appears to stem from this commit in SQLAlchemy, which modified the signature of In hindsight, it seems this API is less stable than I had initially assumed. To improve code robustness, we should add dedicated functions for each I'm looking into this, now. |
Contributor
|
Superseded by #79. Let's close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Problem
In Firebird 3 (tested with the
fdbdriver), the original_render_string_typemethod expected atype_object with attributes like.length,.charset, and.collation. However, it was being called with plain arguments instead, leading to incorrect SQL type rendering and runtime errors such as:File "~\Desktop\nexus\venv\Lib\site-packages\sqlalchemy_firebird\base.py", line 436, in _render_string_type
text = text + (length and "(%d)" % length or "")
✅ Solution
_render_string_typeto accept direct parameters:name,length, andcollation.type_.🔍 Notes
sqlalchemy.sql.compiler._render_string_type.sqlalchemy-firebird==2.1fdbdriver