Skip firstbytes / lastbytes#89
Closed
AlwaysHC wants to merge 4 commits intopauldreik:mainfrom
Closed
Conversation
fziglio
reviewed
Aug 23, 2022
Comment on lines
+17
to
+19
| $rdfind -skip $skiptype -deleteduplicates true a b | ||
| [ -e a ] | ||
| [ ! -e b ] |
There was a problem hiding this comment.
This is testing that the new options are accepted. Which is good. But would be possible to even check the output and see if the option really took effects? Or that another invalid option lead to error?
Just a new user of this program, please ignore if the suggestion does not make sense.
Owner
|
thank you for the PR! it stands out in that it actually adds testing, something that is almost always left out. I implemented this functionality in #208 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a skip option to avoid the
"Now eliminating candidates based on first bytes"
"Now eliminating candidates based on last bytes"
step
#88