libc aarch64: Fix use of the END macro for timingsafe_memcmp #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like a copy and paste error, using timingsafe_bcmp instead of timingsafe_memcmp. This causes the ELF function size to be 0. And that prevents Valgrind from being able to redirect this symbol.
|
Thank you for taking the time to contribute to FreeBSD!
Please review CONTRIBUTING.md, then update and push your branch again. |
paulfloyd
changed the title
Owner
Author
|
I made the change directly in GitHub when I saw that it was very small, which is why there is no signed-off-by: line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like a copy and paste error, using timingsafe_bcmp instead of timingsafe_memcmp.
This causes the ELF function size to be 0. And that prevents Valgrind from being able to redirect this symbol.
I've also logged a Bugzilla item
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289845