I found a bug in JavaScript implementation #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmfgerrit
pushed a commit
to wikimedia/mediawiki-services-parsoid
that referenced
this pull request
May 24, 2018
Fixes the roundtripping on http://localhost:8000/_rt/zhwiki/%E5%A4%A9%E8%8A%B1%E6%B9%96%E6%B0%B4%E5%BA%AB Added a test to catch regressions. Sadly, simplediff is prone to this same type of bug, when "constructor" is split as a word, its `oldIndexMap` gets confused. This is tracked as, paulgb/simplediff#19 Bug: T195227 Change-Id: I7e9f5699a6f73e5d4b3cd88bca5ddca0dff279df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I found a little bug that if before text contains a word like "constructor" an error occurs and I fixed it. I'm very impressed by your diff library and it would be great if you check this. Thanks.