TDAmapper Improvements #7
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @paultpearson,
Love your package! I'm doing quite a bit of research into Mapper, and am in need of a fast Mapper implementation. I believe in reproducible research and prefer to stay open-source in the R world, so here I am!
I forked the package and rewrote the algorithmic portion using Reference Classes. A brief overview of the pull request is available here:
http://htmlpreview.github.io/?https://github.com/peekxc/TDAmapper/blob/master/mapper_ex.html
Notable changes:
This PR isn't comprehensive "CRAN"-ready, but I wanted to get your opinion on the whether the initial changes were something you wouldn't mind pulling in.