[WIP] Consolidate Declaration types. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an awesome step in the right direction IMO. The fixme's will obviously have to be addressed. Do you need help with any of them? |
Owner
Author
All of them I think! |
lol, ok, will revisit later. |
Owner
Author
There was a problem hiding this comment.
I'm just not sure how to get this information.
Owner
Author
|
I left some comments explaining where I got stuck. Help me, @jpsim-kenobi. You're my only hope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows on from jpsim#112 and is inspired by #1 (comment).
cc @jpsim