Skip to content

fix: Duplicate own position marker when change props #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Duplicate own position marker when change props #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7491c3d
fix: Duplicate own position marker when change props
CarlosSTS Jun 10, 2025
c2a3323
fix: Remove own position marker when not exists
CarlosSTS Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/src/main/assets/leaflet.html
View file
Open in desktop

Large diffs are not rendered by default.

29 changes: 24 additions & 5 deletions src/LeafletView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ const LeafletView: React.FC<LeafletViewProps> = ({
}) => {
const webViewRef = useRef<WebView>(null);
const [initialized, setInitialized] = useState(false);
const ownPositionMarkerRef = useRef<boolean>(false);

const logMessage = useCallback(
(message: string) => {
Expand Down Expand Up @@ -206,13 +207,31 @@ const LeafletView: React.FC<LeafletViewProps> = ({

//Handle ownPositionMarker update
useEffect(() => {
if (!initialized || !ownPositionMarker) {
if (!initialized) {
return;
}
sendMessage({
ownPositionMarker: { ...ownPositionMarker, id: OWN_POSTION_MARKER_ID },
});
}, [initialized, ownPositionMarker, sendMessage]);

if (ownPositionMarker) {
ownPositionMarkerRef.current = true;
sendMessage({
ownPositionMarker: { ...ownPositionMarker, id: OWN_POSTION_MARKER_ID },
});
} else if (ownPositionMarkerRef.current) {
ownPositionMarkerRef.current = false;
sendMessage({
ownPositionMarker: {
id: OWN_POSTION_MARKER_ID,
position: {
lat: 0,
lng: 0,
},
title: '',
size: [0, 0],
icon: '',
},
});
}
}, [initialized, ownPositionMarker, sendMessage, ownPositionMarkerRef]);

//Handle mapCenterPosition update
useEffect(() => {
Expand Down