Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Suppose your project directory is
C:\Users\username\myproject
and the source map is trying to loadindex.js
. After running the following snippet:then
filePath
is set toC:\Users\username\myproject
. This is becauseWEBPACK_SUBSTRING_INDEX
is greater than the length of"index.js"
(11 > 8), sosource.substring(WEBPACK_SUBSTRING_INDEX)
returns an empty string. In fact,WEBPACK_SUBSTRING_INDEX
is completely arbitrary. The program continues as normal, expecting thatfilePath
is a file path, and tries to write to said file. Except, it's a directory, sofs.writeFileSync
fails:Changes
WEBPACK_SUBSTRING_INDEX
and subsequentsubstring
call*Note that I use npm rather than Yarn, so if the project runs without these changes, then feel free to discard this particular change.
Support
Versions tested:
v24.0.0
11.6.0