Skip to content

Cleanup code #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
8ctopus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cleanup code #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lib/IgraalOSL/StatsTable/StatsTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public function removeColumns(array $columns)
*/
protected function removeColumnsInLine(array &$line, array $columnsMap)
{
foreach ($line as $k => $v) {
foreach (array_keys($line) as $k) {
if (array_key_exists($k, $columnsMap)) {
unset($line[$k]);
}
Expand Down Expand Up @@ -181,13 +181,12 @@ public function sortMultipleColumn($columns)

/**
* Sort stats table by multiple column with a custom compare function
* @param $columns $columns Associative array : KEY=> column name (string), VALUE=> Custom function (function)
* @param array $columns Associative array : KEY=> column name (string), VALUE=> Custom function (function)
* @return $this
*/
public function uSortMultipleColumn($columns)
{
$dataFormats = $this->dataFormats;
$sort = function ($a, $b) use ($columns, $dataFormats) {
$sort = function ($a, $b) use ($columns) {
foreach ($columns as $colName => $fn) {
$tmp = $fn($a[$colName], $b[$colName]);
if ($tmp !== 0) {
Expand Down