rpcclient: add WithContext methods for context-aware HTTP cancellation#17
Open
rpcclient: add WithContext methods for context-aware HTTP cancellation#17
Conversation
Adds a ctx field to jsonRequest and uses http.NewRequestWithContext in handleSendPostMessage, allowing callers to cancel in-flight HTTP requests via context. Also adds early bail-out on context cancellation during retry backoff. New methods: SendCmdWithContext, RawRequestWithContext, RawRequestAsyncWithContext, and WithContext variants for GetBlockCount, GetBlockHash, GetBlockVerbose, GetBlockVerboseTx, EstimateSmartFee, GetRawTransactionVerbose, CreateRawTransaction, SendRawTransaction, GetTransaction, GetNetworkInfo. CHAINS-6696 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://itbitwiki.atlassian.net/browse/CHAINS-6696
Summary
ctx context.Contextfield tojsonRequeststruct and useshttp.NewRequestWithContextinhandleSendPostMessage, allowing callers to cancel in-flight HTTP requests via contextSendCmdWithContext,RawRequestWithContext,RawRequestAsyncWithContext, andWithContextvariants forGetBlockCount,GetBlockHash,GetBlockVerbose,GetBlockVerboseTx,EstimateSmartFee,GetRawTransactionVerbose,CreateRawTransaction,SendRawTransaction,GetTransaction,GetNetworkInfoContext
BTC-family RPC clients leak goroutines when RPCs hang. The
timeout.RunWithTimeout()wrapper creates a goroutine for each RPC call, but when the timeout fires, the goroutine keeps running because the underlying HTTP request can't be cancelled. This change adds context support so that whenRunWithTimeoutcancels the context, the underlying HTTP request is immediately aborted.