Skip to content

PayjpCardScannerPluginの削除#96

Merged
koutaku921 merged 2 commits intopayjp:masterfrom
bu-tokumitsu:fix/remove_android_cardio_plugin
Oct 14, 2025
Merged

PayjpCardScannerPluginの削除#96
koutaku921 merged 2 commits intopayjp:masterfrom
bu-tokumitsu:fix/remove_android_cardio_plugin

Conversation

@bu-tokumitsu
Copy link
Copy Markdown
Contributor

@bu-tokumitsu bu-tokumitsu commented Oct 2, 2025

概要

  • カードスキャナープラグインの削除

  • 対応内容

    • 16KB Page Sizeサポートに対応していないライブラリがメンテナンスされていない為、スキャンプラグインを削除

関連Issues

動作検証

  • Pixel 7 Pro(emulator:Android 13)
  • iOSも動作検証済み
変更前 変更後

CardIOが除外されているかexampleで確認

公式ページのcheck_elf_alignment.sh スクリプトを使用するの手順で確認

apkはexampleで flutter build apk を実行して生成
修正後にCardIOは取り除かれていることは確認、出力されている残りエラーはパッケージ外の問題なので今回の修正対象外と判断しています

  • 修正前
Recursively analyzing app-release-master.apk

=== APK zip-alignment ===
 1088327 lib/arm64-v8a/libapp.so (OK - compressed)
 2576695 lib/arm64-v8a/libcardioDecider.so (OK - compressed)
 2580133 lib/arm64-v8a/libcardioRecognizer.so (OK - compressed)
 3339342 lib/arm64-v8a/libcardioRecognizer_tegra2.so (OK - compressed)
 3737033 lib/arm64-v8a/libflutter.so (OK - compressed)
 8922092 lib/arm64-v8a/libopencv_core.so (OK - compressed)
10090510 lib/arm64-v8a/libopencv_imgproc.so (OK - compressed)
23065737 lib/x86_64/libapp.so (OK - compressed)
24575540 lib/x86_64/libcardioDecider.so (OK - compressed)
24578990 lib/x86_64/libcardioRecognizer.so (OK - compressed)
25368716 lib/x86_64/libcardioRecognizer_tegra2.so (OK - compressed)
25792305 lib/x86_64/libflutter.so (OK - compressed)
31092796 lib/x86_64/libopencv_core.so (OK - compressed)
32248885 lib/x86_64/libopencv_imgproc.so (OK - compressed)
Verification succesful
=========================

=== ELF alignment ===
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/mips/libcardioDecider.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/armeabi-v7a/libflutter.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/armeabi-v7a/libopencv_core.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/armeabi-v7a/libcardioRecognizer_tegra2.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/armeabi-v7a/libapp.so: \e[32mALIGNED\e[0m (2**14)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/armeabi-v7a/libcardioRecognizer.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/armeabi-v7a/libcardioDecider.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/armeabi-v7a/libopencv_imgproc.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/x86/libopencv_core.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/x86/libcardioRecognizer_tegra2.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/x86/libcardioRecognizer.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/x86/libcardioDecider.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/x86/libopencv_imgproc.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/arm64-v8a/libflutter.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/arm64-v8a/libopencv_core.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/arm64-v8a/libcardioRecognizer_tegra2.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/arm64-v8a/libapp.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/arm64-v8a/libcardioRecognizer.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/arm64-v8a/libcardioDecider.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/arm64-v8a/libopencv_imgproc.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/armeabi/libcardioDecider.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/x86_64/libflutter.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/x86_64/libopencv_core.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/x86_64/libcardioRecognizer_tegra2.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/x86_64/libapp.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/x86_64/libcardioRecognizer.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/x86_64/libcardioDecider.so: \e[31mUNALIGNED\e[0m (2**12)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-master_out_XXXXX.6U43p7cNkJ/lib/x86_64/libopencv_imgproc.so: \e[31mUNALIGNED\e[0m (2**12)
-e \e[31mFound 16 unaligned libs (only arm64-v8a/x86_64 libs need to be aligned).\e[0m
=====================
  • 修正後
Recursively analyzing app-release-pr96.apk

=== APK zip-alignment ===
 1051049 lib/arm64-v8a/libapp.so (OK - compressed)
 2539411 lib/arm64-v8a/libflutter.so (OK - compressed)
13836137 lib/x86_64/libapp.so (OK - compressed)
15345934 lib/x86_64/libflutter.so (OK - compressed)
Verification succesful
=========================

=== ELF alignment ===
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-pr96_out_XXXXX.A87hXrDA4K/lib/armeabi-v7a/libflutter.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-pr96_out_XXXXX.A87hXrDA4K/lib/armeabi-v7a/libapp.so: \e[32mALIGNED\e[0m (2**14)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-pr96_out_XXXXX.A87hXrDA4K/lib/arm64-v8a/libflutter.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-pr96_out_XXXXX.A87hXrDA4K/lib/arm64-v8a/libapp.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-pr96_out_XXXXX.A87hXrDA4K/lib/x86_64/libflutter.so: \e[32mALIGNED\e[0m (2**16)
-e /var/folders/h_/n0jq1fxd0pl_s6v3xkfrgn9r0000gq/T/app-release-pr96_out_XXXXX.A87hXrDA4K/lib/x86_64/libapp.so: \e[32mALIGNED\e[0m (2**16)
-e ELF Verification Successful
=====================

@bu-tokumitsu bu-tokumitsu marked this pull request as ready for review October 2, 2025 11:53
@bu-tokumitsu
Copy link
Copy Markdown
Contributor Author

@yatatsu @laiso cc: @koutaku921
レビューお願いいたします。

Copy link
Copy Markdown
Contributor

@yatatsu yatatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@koutaku921 koutaku921 merged commit cec4ec0 into payjp:master Oct 14, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants