Skip to content

Improvements/eload service app#647

Merged
joemarct merged 4 commits intomasterfrom
improvements/eload-service-app
Mar 19, 2026
Merged

Improvements/eload service app#647
joemarct merged 4 commits intomasterfrom
improvements/eload-service-app

Conversation

@SeanNikki123
Copy link
Copy Markdown
Collaborator

@SeanNikki123 SeanNikki123 commented Mar 19, 2026

Description

Added fixes and adjustment for the eload-tab (eload-form/history page). adjusted all scroll height to fix see more button not visible. Added missing skeleton loaders. And fixed issue of new order not appearing, added pending display.

Fixes # (issue)

  • Fixed scroll height for category and promo selector on eload form, and order list on order history page to accomodate new eload tab.
  • Fixed: see more button/loader not visible
  • Removed eload tab on order detail page and fixed updated back button route to redirect to order history
  • Added missing skeleton loaders
  • Disable eload tabs button on loading initial auth request
  • Updated order detail page display for pending orders
  • Fixed: Newly created order (orders w/o gbits order id/pending orders) now appears on the order list

Type of Change

  • UI improvements with no business logic changes
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Test Notes

Tested manually

@mentions

@joemarct

@SeanNikki123 SeanNikki123 requested a review from joemarct March 19, 2026 05:25
@opencode-agent
Copy link
Copy Markdown

PR Review Summary

Changes Overview:
This PR makes UI improvements to the Eload service app with scroll height adjustments, better navigation, and improved loading states.

Files Changed:

1. eload-form.vue - Scroll height adjustments for new tab UI

  • Category scroll: minHeight - 275minHeight - 325
  • Promo scroll: minHeight - 300minHeight - 360
  • Reduced skeleton loaders from 3 to 2 (more accurate representation)

2. eload-history.vue - Order list scroll height

  • Adjusted from 80vh to 70vh to accommodate the new tabs

3. eload-history-details.vue - Skeleton and order ID display

  • Increased skeleton height from 180px to 300px (better visual balance)
  • Added fallback '???' for missing order IDs

4. index.vue - Tab navigation improvements (major changes)

  • Tabs now hidden on order-details page (v-if condition)
  • Tabs disabled during loading (:disabled="!isloaded")
  • Dynamic back navigation: returns to orders list from details page
  • Tabs moved outside content template to show during loading

Review Notes:

Good practices observed:

  • Proper conditional rendering for tab visibility
  • Disabled states prevent interaction during loading
  • Clean separation of concerns
  • Consistent dark mode support
  • No breaking logic changes

UX improvements:

  • Better scroll heights accommodate the new tab interface
  • Proper back button routing from order details
  • Loading skeletons match actual content better

Recommendation: Approve - These are clean UI improvements with no business logic changes. The code follows existing patterns and enhances user experience without introducing risks.

New%20session%20-%202026-03-19T05%3A26%3A29.354Z
opencode session  |  github run

@joemarct joemarct merged commit ba84fc2 into master Mar 19, 2026
1 check passed
@joemarct joemarct deleted the improvements/eload-service-app branch March 19, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants