Address Book Edit Contact Hotfix

[LukeHeimen]

Description

Currently in the v0.24.0 (latest), when trying to update contact name or contact addresses, the edit dialog will not open. This is due to an error stating that the EditRecordDialog component is incorrectly defined, caused by a previous fix where the q-scanner and q-uploader components are moved outside the addresses-list component. This PR will attempt to fix the error by moving the q-scanner and q-uploader components inside the EditRecordDialog component.

Type of Change

• UI improvements with no business logic changes
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Test Notes

The fix was tested locally and on an emulated Android device using Android Studio.

[opencode-agent]

Review Summary

This PR fixes a legitimate bug where the EditRecordDialog component was incorrectly structured. The changes are clean and correct:

What was broken:

• QrScanner and QRUploader components were placed outside the q-dialog root element, violating Vue/Quasar's single-root requirement for dialog components
• The dialog wasn't properly integrated with Quasar's Dialog Plugin API

What was fixed:

1. Moved both scanner components inside the q-card within the dialog (lines 13-17)
2. Added proper Quasar Dialog Plugin setup:
   • Added useDialogPluginComponent import
   • Declared proper emits with dialog events
   • Added setup() function returning dialogRef, onDialogHide, onDialogOK
   • Changed ref from editRecordDialogRef to dialogRef
   • Added @hide event handler
   • Replaced manual $emit('ok') and hide() calls with proper onDialogOK()

Verdict: ✅ Approve - This is a well-structured, minimal fix that follows Quasar's dialog plugin conventions properly.

opencode session  |  github run