Os VT 2 - Providers implemented #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indrajra
requested changes
Mar 25, 2019
| @@ -0,0 +1,31 @@ | |||
| package io.opensaber.provider; | |||
Collaborator
There was a problem hiding this comment.
Move this into another package altogether and call it as an example. Say, src/main/java/org/example/provider
| result.put(field.getTitle(), evaluator.evaluate().toString()); | ||
|
|
||
| Object evaluatedValue = evaluator.evaluate(); | ||
| if(evaluatedValue instanceof String){ |
Collaborator
There was a problem hiding this comment.
Did you test that JsonNodeFactory.instance.pojoNode(evaluatedValue)); will not work for String? Asking if we should really have if-else here.
Owner
Author
There was a problem hiding this comment.
Have tested this, does not work for String. Hence I preferred a check.
src/test/resources/personVT1.json
Outdated
| { | ||
| "title": "Name in passport", | ||
| "function": "#/functionDefinitions/concat($lastName, $firstName)", | ||
| "function": "#/functionDefinitions/userDefinedConcat($lastName, $firstName)", |
Collaborator
There was a problem hiding this comment.
Create a sample with both in-line and provider and ref for test purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 changes done-
Introduced IEvaluator: public T evaluate() and EvaluatorFactory: getInstance()
Impl classes added :- ProviderEvaluator and FunctionEvaluator
Added impl class SampleViewFunctionProvider (IViewFunctionProvider)
SampleViewFunctionProvider : doAction() called by ProviderEvaluator:evaluate()
Note: No impl for reference is present