ci(async-audit): Phase 4 — enforce async-route audit#248
Merged
Conversation
Drop the soft-fail flags so any new ASYNC* violation hard-fails: - ``.github/workflows/ci.yml``: remove ``continue-on-error: true`` from the ``async-route-audit`` job and ``--exit-zero`` from the ruff command. Rename to "Async-route audit (BUG-JD-10 class)". - ``.pre-commit-config.yaml``: remove ``--exit-zero`` from the ``ruff-async-audit`` hook so violations block commits. Repo reached zero visible violations at end of Phase 3 (PR #247). Verified ``ruff check --select ASYNC src/`` exits clean. Third of four Phase 4 PRs (data → cascor → canopy → worker). Refs: notes/ASYNC_ROUTE_AUDIT_HOOK_MIGRATION_PLAN.md §4 (in juniper-ml) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4 of the async-route audit migration (juniper-ml ASYNC_ROUTE_AUDIT_HOOK_MIGRATION_PLAN.md §4). Drops the soft-fail flags so any new BUG-JD-10-class violation hard-fails.
Third of four Phase 4 PRs: data (#98) → cascor (#235) → canopy → worker.
Changes
.github/workflows/ci.ymlcontinue-on-error: truefrom theasync-route-auditjob.--exit-zerofrom the ruff command (annotations still render via--output-format=github)..pre-commit-config.yaml--exit-zerofrom theruff-async-audithook so violations block commits locally.Verification
ruff check --select ASYNC src/exits clean (PR fix(async-audit): Phase 3 cleanup — eliminate sync I/O in async routes #247 cleared the last 5 violations: snapshot route helpers, mkdir thread-hop, ASYNC109/ASYNC110 noqas with justifications)async-route-auditjob goes green on this PRTest plan
🤖 Generated with Claude Code