Skip to content

ci(scheduled-tests): tolerate exit-5 until repo grows slow/integration tests#43

Merged
pcalnon merged 1 commit intomainfrom
fix/p12-data-client-scheduled-tests
May 4, 2026
Merged

ci(scheduled-tests): tolerate exit-5 until repo grows slow/integration tests#43
pcalnon merged 1 commit intomainfrom
fix/p12-data-client-scheduled-tests

Conversation

@pcalnon
Copy link
Copy Markdown
Owner

@pcalnon pcalnon commented May 4, 2026

This repo's Scheduled Tests workflow has been failing on every nightly run since it landed because the test suite has no tests marked `@pytest.mark.slow` or `@pytest.mark.integration` — `pytest -m "slow or integration"` exits 5 (no tests collected) and the workflow treats that as failure.

Soften the run step to swallow exit-5 specifically. Every other non-zero exit (real test failures, infrastructure errors) is still preserved.

Once this repo grows tests marked with either marker the schedule starts exercising them automatically — no further workflow change needed.

Refs cross-repo CI audit, P-12/P-13 (identical fix to data-client and cascor-client).

…grows slow/integration markers (P-12/P-13)

The canonical Scheduled Tests template runs
``pytest -m "slow or integration"``. This repo's test suite has no
tests decorated with either marker, so pytest exits 5 ("no tests
collected") and the workflow has been failing on every nightly run
since the workflow landed.

Soften the run step to swallow exit-5 specifically — every other
non-zero exit is still preserved as failure, so a real test
regression once such tests exist will still surface. The schedule
will start exercising real tests automatically the first time a test
in this repo gets ``@pytest.mark.integration`` (the registered
marker in pyproject.toml).

Refs cross-repo CI audit, P-12 (juniper-data-client) /
P-13 (juniper-cascor-client) — both repos receive the identical fix.
@pcalnon pcalnon self-assigned this May 4, 2026
Copy link
Copy Markdown
Owner Author

@pcalnon pcalnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@pcalnon pcalnon merged commit a52f281 into main May 4, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant