Merged
Conversation
Cross-repo CI audit found juniper-data-client's bandit step was a
single ``bandit … || true`` with no follow-up blocking invocation, so
any genuine finding was silently tolerated. Mirror the canonical
two-step pattern used in cascor / data (and now extended in
juniper-data PR #67):
1. **SARIF generation** — ``bandit … -f sarif -o ... --exit-zero``.
Always succeeds so the GitHub Security upload has a file regardless
of findings.
2. **Blocking gate** — ``bandit … --confidence-level medium
--severity-level medium``. Fails the job on medium-or-higher
findings.
Also harden the SARIF upload with
``hashFiles('reports/security/bandit.sarif') != ''`` to keep the
upload step green if a future security-tools regression prevents
bandit from emitting the file.
Verified locally — current ``juniper_data_client`` has 0 medium /
high findings, so the new gate is non-blocking on this commit. Any
future medium-or-higher finding will now fail CI.
Refs cross-repo CI audit P-20.
pcalnon
force-pushed
the
fix/p20-bandit-blocking-gate
branch
from
4119249 to
d8fc259
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-repo CI audit P-20: data-client's bandit was
|| truewith no blocking follow-up — any finding silently tolerated. Mirror cascor/data's two-step pattern: SARIF with --exit-zero (for upload), then blocking gate at medium severity. Verified locally: 0 medium/high findings on current main.Refs cross-repo CI audit P-20.