Skip to content

ci(workflow): force gitleaks-action onto Node.js 24 + drop invalid 'fail' input#52

Merged
pcalnon merged 1 commit intomainfrom
ci/gitleaks-force-node24
May 6, 2026
Merged

ci(workflow): force gitleaks-action onto Node.js 24 + drop invalid 'fail' input#52
pcalnon merged 1 commit intomainfrom
ci/gitleaks-force-node24

Conversation

@pcalnon
Copy link
Copy Markdown
Owner

@pcalnon pcalnon commented May 6, 2026

Summary

  • Add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true" to the gitleaks-action env block (Node.js 24 forced-cutover protection).
  • Drop the invalid fail: true input — gitleaks-action v2.3.9 has no fail input, and passing it triggers Unexpected input(s) 'fail' warnings.

Why

GitHub forces Node.js 20 actions onto Node.js 24 on 2026-06-02. gitleaks-action v2.3.9 has no Node.js 24 release (upstream PR #215 in flight). The documented escape hatch eliminates the deprecation warning now and protects against the upcoming cutover.

The fail input never existed in v2.3.9 — the action exits non-zero on leaks by default, so dropping the input preserves behavior.

Mirrors juniper-cascor#224 (which already shipped both fixes for cascor).

Test plan

  • CI green
  • Node.js 20 actions are deprecated warning gone
  • Unexpected input(s) 'fail' warning gone

🤖 Generated with Claude Code

…ail' input

Two related fixes to the gitleaks-action invocation:

1. GitHub forces all Node.js 20 actions onto Node.js 24 on 2026-06-02.
   gitleaks-action v2.3.9 has no released Node.js 24 build (PR #215
   upstream is in flight). Opt in now via the documented
   FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env override.

2. gitleaks-action v2.3.9 has no ``fail`` input — passing it produces
   ``Unexpected input(s) 'fail', valid inputs are ['']`` warnings in
   CI. The action exits non-zero on leaks by default, which is the
   behavior we want, so drop the input.

Drop the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 override once gitleaks-
action publishes a node24-pinned release.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Owner Author

@pcalnon pcalnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@pcalnon pcalnon merged commit 37310d0 into main May 6, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant