Skip to content

ci(async-audit): Phase 4 — enforce async-route audit #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcalnon merged 2 commits into from
May 7, 2026
+10 −17
Merged

ci(async-audit): Phase 4 — enforce async-route audit #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65a8563
ci(async-audit): Phase 4 — enforce async-route audit
pcalnon May 6, 2026
5a76ff9
Merge branch 'main' into ci/async-route-audit-phase-4-enforce
pcalnon May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,16 +122,15 @@ jobs:
python scripts/check_doc_links.py --exclude templates --exclude history --cross-repo skip

# ═══════════════════════════════════════════════════════════════════════════════════════════════
# Async-route audit (Phase 2 — soft-fail visibility).
# Async-route audit (Phase 4 — enforced).
# Catches the BUG-JD-10 bug class (sync-blocking calls inside async def
# route handlers). `continue-on-error: true` so violations surface as
# PR annotations without blocking merge. Phase 4 will flip this off.
# route handlers). Hard-fails on any new violation; this repo reached
# zero violations at end of Phase 3 (PR #96).
# See juniper-ml notes/ASYNC_ROUTE_AUDIT_HOOK_MIGRATION_PLAN.md §4.
# ═══════════════════════════════════════════════════════════════════════════════════════════════
async-route-audit:
name: Async-route audit (BUG-JD-10 class, soft-fail)
name: Async-route audit (BUG-JD-10 class)
runs-on: ubuntu-latest
continue-on-error: true

steps:
- name: Checkout Code
Expand All @@ -150,12 +149,7 @@ jobs:
echo "╔════════════════════════════════════════════════════════════╗"
echo "║ JuniperData - Async-route audit (BUG-JD-10) ║"
echo "╚════════════════════════════════════════════════════════════╝"
# --exit-zero: same soft-fail contract as the pre-commit hook
# (Phase 2 "violations as warnings, not blockers"). Annotations
# still render via --output-format=github so reviewers see them
# in the PR; the step itself doesn't fail. Phase 4 will drop
# this flag along with `continue-on-error: true` on the job.
ruff check --select ASYNC --exit-zero --output-format=github juniper_data/
ruff check --select ASYNC --output-format=github juniper_data/

# ═══════════════════════════════════════════════════════════════════════════════════════════════
# Unit Tests: Run unit tests with coverage enforcement
Expand Down
11 changes: 5 additions & 6 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,16 +97,15 @@ repos:
name: Format with Ruff
files: ^juniper_data/.*\.py$
# ─────────────────────────────────────────────────────────────────────
# Async-route audit (Phase 2 — soft-fail visibility).
# Async-route audit (Phase 4 — enforced).
# See juniper-ml notes/ASYNC_ROUTE_AUDIT_HOOK_MIGRATION_PLAN.md.
# `--exit-zero` keeps violations as warnings (won't block commits).
# CI lane in .github/workflows/ci.yml runs the same check with
# `continue-on-error: true` so PRs see annotations without blocking
# merge. Phase 4 will drop both `--exit-zero` and `continue-on-error`.
# Hard-fails on any new ASYNC* violation. The repo reached zero
# violations at end of Phase 3 (PR #96); per-file-ignores live in
# pyproject.toml [tool.ruff.lint.per-file-ignores].
- id: ruff
alias: ruff-async-audit
name: Async-route audit (BUG-JD-10 class)
args: [--select, ASYNC, --exit-zero]
args: [--select, ASYNC]
files: ^juniper_data/.*\.py$
stages: [pre-commit, manual]

Expand Down
Loading