Skip to content

docs(notes): track gitleaks Node24 override removal followup#230

Merged
pcalnon merged 1 commit intomainfrom
docs/followup-gitleaks-node24-override
May 6, 2026
Merged

docs(notes): track gitleaks Node24 override removal followup#230
pcalnon merged 1 commit intomainfrom
docs/followup-gitleaks-node24-override

Conversation

@pcalnon
Copy link
Copy Markdown
Owner

@pcalnon pcalnon commented May 6, 2026

Summary

Adds `notes/FOLLOWUP_GITLEAKS_NODE24_OVERRIDE.md` documenting the open obligation to remove `FORCE_JAVASCRIPT_ACTIONS_TO_NODE24` from every gitleaks-action invocation once upstream ships a node24-pinned release.

Why

The 2026-05-06 ecosystem-wide override (6 repos) was a temporary measure. Without an in-tree tripwire it could outlive its purpose. The notes file documents:

Companion artifacts:

  • juniper-ml#229 — GitHub tracking issue (links back to this file)
  • Memory entry on the same followup (separate, for Claude session continuity)
  • Existing in-workflow comments in each repo's `ci.yml` (added in the original 6 PRs)

Test plan

  • CI green
  • Doc renders correctly on GitHub

🤖 Generated with Claude Code

On 2026-05-06 we set FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true on every
gitleaks-action invocation across the ecosystem (6 repos) to silence
the Node.js 20 deprecation warning ahead of GitHub's 2026-06-02
forced-migration. The override is temporary — must be removed once
gitleaks-action publishes a release that runs on Node.js 24
natively.

This notes file documents:
- Why the override exists
- Detection signals (upstream PR #215 / #207 merge, action.yml runs.using)
- The removal procedure (one-line edit per repo, six repos)
- Locator command for finding the override line
- Tripwires for the 2026-06-02 cutover

Tracked in juniper-ml#229.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@pcalnon pcalnon self-assigned this May 6, 2026
Copy link
Copy Markdown
Owner Author

@pcalnon pcalnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@pcalnon pcalnon merged commit 6472e22 into main May 6, 2026
19 checks passed
@pcalnon pcalnon deleted the docs/followup-gitleaks-node24-override branch May 6, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant