Conversation
…and (lesson learned) The original Phase 2 CI command omitted ``--exit-zero``. First run on juniper-data PR #94 surfaced the issue: ruff exits 1 when violations are present, the step fails, and the ``async-route-audit`` job displays as red on the PR — even with ``continue-on-error: true`` on the job. The job-level flag prevents the workflow from failing as a whole, but does not suppress the visual red indicator. Updates Phase 2's example command to include ``--exit-zero`` alongside ``--output-format=github``, and adds a "Lesson learned" callout explaining the interaction. Future Phase 2 PRs (canopy, worker) will use the corrected pattern from the start. The two already-open Phase 2 PRs (juniper-data #94, juniper-cascor #232) have been fixed up with the same change in their CI workflow files. Phase 4 will drop both ``--exit-zero`` and ``continue-on-error: true`` simultaneously to flip enforcement on. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The original Phase 2 CI command in
`notes/ASYNC_ROUTE_AUDIT_HOOK_MIGRATION_PLAN.md` omitted
`--exit-zero`. First run on juniper-data #94
surfaced the issue: ruff exits 1 when violations are present, the
step fails, and the `async-route-audit` job displays as red on
the PR — even with `continue-on-error: true` on the job.
`continue-on-error: true` prevents the workflow from failing
as a whole but doesn't suppress the visual red indicator on the
step. Adding `--exit-zero` makes the step exit 0 (so the job
stays green) while `--output-format=github` still renders the
violations as PR annotations. Belt and suspenders alongside
`continue-on-error`.
What changes
interaction so future readers don't repeat the mistake.
Pairs with
adding `--exit-zero` to the CI step.
`fb1b5d4` (proactive: cascor has 0 visible violations today,
but the change ensures the soft-fail contract holds for any
future violation).
When canopy and worker Phase 2 PRs are written (after their
Phase 1 PRs land), they'll use the corrected pattern from the
start.
Test plan
🤖 Generated with Claude Code