docs(async-audit): track deferred follow-ups in dedicated tracker#234
Merged
docs(async-audit): track deferred follow-ups in dedicated tracker#234
Conversation
Adds notes/FOLLOWUP_ASYNC_ROUTE_AUDIT.md mirroring the existing FOLLOWUP_GITLEAKS_NODE24_OVERRIDE.md pattern so the two non-code items deferred at Phase-4 close-out don't slip: 1. Branch-protection required-checks promotion in 4 repos (UI-only, ~30 min total). Includes per-repo procedure + a `gh api` scripted alternative + a periodic don't-forget-tripwire one-liner. 2. Optional centralised deny-list (juniper-ml/util/check_async_routes.py per migration plan §5.2 / Q3). Captures concrete triggers (the conditions under which we'd actually build it) and a 5-bullet implementation outline so future-us doesn't have to rederive scope from the migration plan. Updates the migration plan's Open follow-ups bullet list to link to the new tracker so anyone reading the plan finds the followup doc without a separate search. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Captures the two non-code follow-ups deferred at end of the async-route audit migration so they don't slip through the cracks:
juniper-ml/util/check_async_routes.pyper migration plan §5.2 / Q3) — captures concrete triggers under which we'd actually build it, and a 5-bullet implementation outline.Mirrors the existing
FOLLOWUP_GITLEAKS_NODE24_OVERRIDE.mdpattern. Updates the migration plan's "Open follow-ups" bullet list to link to the new tracker so anyone reading the plan finds the followup doc without a separate search.Context
PR #233 closed out the migration but only added a single "Open follow-ups" paragraph at the bottom of the plan. That paragraph would get buried as the plan is referenced for other reasons. A dedicated tracker doc gives each item:
Files
notes/FOLLOWUP_ASYNC_ROUTE_AUDIT.md(new, 117 lines)notes/ASYNC_ROUTE_AUDIT_HOOK_MIGRATION_PLAN.md(3-line edit to link to the new doc from the §0 ledger)Test plan
util/check_doc_links.pyreports no new broken links — verified locally; only pre-existingnotes/legacy/breakages remain🤖 Generated with Claude Code