Conversation
Cleanup follow-up to commit b4fd09d (which flipped JUNIPER_WORKER_CONDA's default to JuniperCascor1) and the 2026-05-07 local install of juniper-cascor-worker editable into JuniperCascor1. The header note and the inline comment above ``JUNIPER_WORKER_CONDA="${JUNIPER_WORKER_CONDA:-JuniperCascor1}"`` both still claimed the worker pip wheel "currently lives only in the JuniperCascor env" and recommended pointing the override at JuniperCascor1 — which is now the default and no longer hypothetical. Update both call sites to describe the actual current state, and mark the corresponding follow-up bullet in ``notes/CASCOR_CONDA_ENV_FIX_2026-05-07.md`` as done. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation tidy-up follow-up to commit
b4fd09d(flippedJUNIPER_WORKER_CONDAdefault toJuniperCascor1) and the2026-05-07 local install of
juniper-cascor-workereditable intoJuniperCascor1.The header note and inline comment above the
JUNIPER_WORKER_CONDA="${JUNIPER_WORKER_CONDA:-JuniperCascor1}"assignment both still claimed the worker pip wheel "currently lives
only in the JuniperCascor env" and recommended pointing the override
at
JuniperCascor1— which is now the default and no longerhypothetical. Both comment sites now describe the actual state.
The corresponding follow-up bullet in
notes/CASCOR_CONDA_ENV_FIX_2026-05-07.mdis marked done; the tworemaining open follow-ups (rebuild torch in
JuniperCascor, documentthe env split if it sticks) are kept.
Test plan
🤖 Generated with Claude Code