Skip to content

Large filesize support for 32bit systems#121

Open
goatface wants to merge 1 commit intopcbend:mainfrom
goatface:master
Open

Large filesize support for 32bit systems#121
goatface wants to merge 1 commit intopcbend:mainfrom
goatface:master

Conversation

@goatface
Copy link

@goatface goatface commented May 2, 2017

Files over ~2 GB could not be opened on my 32-bit system. These two modest changes appear to fix the issue.

@Lunderberg
Copy link
Collaborator

Perhaps it would be better if we instead add -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 to the compiling commands. That way, we wouldn't need to get in the habit of using fopen64. This also would avoid causing additional compatibility issues with OSX, which does not provide fopen64, as everything is 64-bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants