Skip to content

Adding string parsing to Weekday. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LennartCode wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding string parsing to Weekday. #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/src/tempo/weekday.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,10 @@ enum Weekday {
///
/// US weekdays are numbered 0=Sunday to 6=Saturday.
int get us => index % 7;

/// Parses a string to a weekday.
///
/// Takes a lower-case weekday name in English and returns the respective enumerated value.
Comment on lines +29 to +31
Copy link
Copy Markdown
Owner

@pcekm pcekm Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets focus more on the idea that this is the inverse of the name field. The fact that it's english isn't all that important. Something like "Parses the output of [name]." You could probably get away with just that single line and no other explanation.

factory Weekday.parse(String string) =>
Weekday.values.skip(1).where((val) => val.name == string).single;
}
Loading