Implement HERTZ and HERO algorithmic based assets.#6
Open
Zapata wants to merge 1 commit intopch957:masterfrom
Open
Implement HERTZ and HERO algorithmic based assets.#6Zapata wants to merge 1 commit intopch957:masterfrom
Zapata wants to merge 1 commit intopch957:masterfrom
Conversation
|
Excellent work @Zapata ! Can we confirm that this functions correctly? There were a few btsprice witnesses on bitsharestalk who use btsprice who could test this out. |
|
BSIP 76 (bitshares/bsips#221) has now set fixed (fake) price feeds for bitUSD. Since this price feed script uses bitUSD as the price feed reference it's now producing inaccurate Hertz price feeds. Can an alternative to bitUSD be provided for Hertz to become accurate again? |
Author
|
@grctest The USD price used to compute the algorithm based assets is computed from CEX order books / tickers and not adjusted using BSIP 76. The code is not impacted by the bitUSD feed. There is nothing to do. |
|
That's a great relief, thanks for the clarification 👍
…On Fri, 18 Oct 2019, 13:03 Zapata, ***@***.***> wrote:
@grctest <https://github.com/grctest> The USD price used to compute the
algorithm based assets is computed from CEX order books / tickers and not
adjusted using BSIP 76. The code is not impacted by the bitUSD feed. There
is nothing to do.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6?email_source=notifications&email_token=ADZAOF7QB7XNFOQTLN3BW73QPGQZTA5CNFSM4EXPVJG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBUD74A#issuecomment-543703024>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZAOF2RESRZ7K2J4FQW3BDQPGQZTANCNFSM4EXPVJGQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4