Open
Conversation
Contributor
|
This issue wasn't assigned to you, but you still submitted a PR. Such PR are generally considered as invalid. |
sarthak247
suggested changes
Oct 14, 2018
Author
|
I thought by asking for taking this issue means assigning yourself, sorry for that. I have updated the program as per the description please see to it. |
Contributor
|
@1Oozaru1 please change the commit message and make every thing in present tense, no past tense required in commit messages, use git amend for the purpose |
sambhavkaul
force-pushed
the
master
branch
2 times, most recently
from
3a68ac2 to
f84e401
Compare
Author
|
@AkshayCHD Done |
divyam3897
requested changes
Oct 24, 2018
AkshayCHD
requested changes
Oct 25, 2018
Contributor
|
@1Oozaru1 Also try to make one commit out of the three (you can use git reset --soft for that) |
Author
|
@AkshayCHD Done Sir, Please see to it. |
sambhavkaul
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a function LengthOfString , issue #73