add c program to check for perfect numbers #71#92
Open
archu5 wants to merge 1 commit intopclubuiet:masterfrom
Open
add c program to check for perfect numbers #71#92archu5 wants to merge 1 commit intopclubuiet:masterfrom
archu5 wants to merge 1 commit intopclubuiet:masterfrom
Conversation
AkshayCHD
requested changes
Oct 23, 2018
programs/C/perf.c
Outdated
| } | ||
| } | ||
| //checking if sum of divisors is equal to entered number or not and then printing required output | ||
| if(sum==n) |
programs/C/perf.c
Outdated
| printf("hurray!,entered number is perfect\n"); | ||
| } | ||
| else | ||
| printf("number is not perfect, try another one\n"); |
programs/C/perf.c
Outdated
| else | ||
| printf("number is not perfect, try another one\n"); | ||
|
|
||
|
|
Contributor
|
also reset --soft the commits into one |
archu5
force-pushed
the
master
branch
2 times, most recently
from
a922160 to
217be62
Compare
Author
|
updated my code #71 |
sagar-kalra
requested changes
Oct 23, 2018
programs/C/per.c
Outdated
| if( sum == n) | ||
| { | ||
| printf("hurray!,entered number is perfect\n"); | ||
| }else |
Contributor
There was a problem hiding this comment.
Still, indentation is not perfect.
programs/C/per.c
Outdated
| printf("hurray!,entered number is perfect\n"); | ||
| }else | ||
| printf("number is not perfect, try another one\n"); | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Try matching the open braces with the closing braces.
divyam3897
requested changes
Oct 24, 2018
programs/C/perfe.c
Outdated
| #include<stdio.h> | ||
|
|
||
| int main() | ||
| { |
Contributor
There was a problem hiding this comment.
Move braces in above line
programs/C/perfe.c
Outdated
| int main() | ||
| { | ||
| int sum = 0, n; | ||
| //prompting user for number to check whether it is perfect or not |
Contributor
There was a problem hiding this comment.
Present tense for comments.
programs/C/perfe.c
Outdated
| printf("please enter number to check whether it is perfect or not:"); | ||
| scanf("%d", &n); | ||
| for( int i = 1; i <= n/2; i++) | ||
| { |
programs/C/perfe.c
Outdated
| scanf("%d", &n); | ||
| for( int i = 1; i <= n/2; i++) | ||
| { | ||
| if( n%i == 0){ //finding sum of divisors of entered number |
Contributor
There was a problem hiding this comment.
no need for braces for single line statements/conditions
programs/C/perfe.c
Outdated
| sum += i; | ||
| } | ||
| }//checking if sum of divisors is equal to entered number or not and then printing required output | ||
| if( sum == n){ |
Contributor
There was a problem hiding this comment.
braces not required, use indentation
programs/C/perfe.c
Outdated
| if( n%i == 0){ //finding sum of divisors of entered number | ||
| sum += i; | ||
| } | ||
| }//checking if sum of divisors is equal to entered number or not and then printing required output |
archu5
changed the title
Author
|
made changes in code as suggested,please check. |
sagar-kalra
requested changes
Oct 25, 2018
Contributor
sagar-kalra
left a comment
sagar-kalra
left a comment
There was a problem hiding this comment.
Don't solve 2 issues in 1 PR.
That's why concept of branching is used.
You can read it about here https://git-scm.com/book/en/v1/Git-Branching-What-a-Branch-Is
Author
|
resolved #71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #71 resolved