Updated CR to allow any number of disconnected regions and any number of percentiles#109
Open
mdhimes wants to merge 6 commits intopcubillos:masterfrom
mdhimes:master
Open
Updated CR to allow any number of disconnected regions and any number of percentiles#109mdhimes wants to merge 6 commits intopcubillos:masterfrom mdhimes:master
mdhimes wants to merge 6 commits intopcubillos:masterfrom
mdhimes:master
Conversation
…r of percentiles. Defaults to 68% and 95% CRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the CR function to work for any number of regions and any number of percentiles. Output displays CRs as (region1lo, region1hi) U (region2lo, region2hi) U ... in a nice format (respects 80-character width). The code to do so is perhaps less than ideal (nested loops), but performance-wise the cost of that is minimal and it works. Plots display each requested CR, where darkest is the lowest percentile (e.g., 68% interval would be a dark grey, and 95% interval would be a light grey). Defaults to both 68% and 95% intervals, as non-Gaussian posteriors need more than 1 CR to properly interpret the results.
Let me know if there are any desired changes before you merge this into master.