Skip to content

Matrix covariance / Update _chisq.c#134

Open
alulujasmine wants to merge 1 commit intopcubillos:masterfrom
alulujasmine:alulujasmine-patch-1
Open

Matrix covariance / Update _chisq.c#134
alulujasmine wants to merge 1 commit intopcubillos:masterfrom
alulujasmine:alulujasmine-patch-1

Conversation

@alulujasmine
Copy link
Copy Markdown

Update the chisq expression in order to take the condition where the uncert is 2-D i.e. a covariance matrix. In this case, chisq = (data-model).T inv(sigma) (data-model).

Update the chisq expression in order to take the condition where the uncert is 2-D i.e. a covariance matrix. In this case, chisq = (data-model).T @ inv(sigma) @ (data-model).
@pcubillos
Copy link
Copy Markdown
Owner

Hi @alulujasmine
Sorry for the late answer, I was on holidays, I'll check and test this in the next couple of days, but on a quick look, it seems alright. Thanks for the contributions!

@alulujasmine
Copy link
Copy Markdown
Author

alulujasmine commented Oct 6, 2021

Thanks for your reply! I am very sorry that I didn't test it because I don't know how to do it. I had tried to download the whole updated package and run it. It didn't work. Thank you very much for taking this update into consideration and being willing to test it!

@pcubillos pcubillos changed the title Update _chisq.c Matrix covariance / Update _chisq.c Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants